fix(core): update package engines.node to correctly include only >=16 #3861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fahslaj
force-pushed
the
fix/update-node-engine-requirement
branch
from
3dc01e0
to
2dfc559
Compare
JamesHenry
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates package.json files to properly exclude Node 14.
Motivation and Context
Node 14 reached end of life on Apr 30th, 2023 (https://endoflife.date/nodejs), which was two months before the release of Lerna v7. Lerna v7 never intended to support Node 14 and the persistence of ^v14.17.0 in the package.json
engines.nodeproperty for Lerna@^7 was an oversight.Checklist: