Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(version): add json option to version command #3858

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

amorscher
Copy link
Contributor

@amorscher amorscher commented Oct 8, 2023

Outputs projects which reveive a new version in json format.

Description

Follwoing json format is supported:

[
  {
    "name": "footer",
    "version": "0.0.4",
    "private": false,
    "location": "/home/ammo/git/lerna-getting-started-example/packages/footer",
    "newVersion": "0.0.5"
  },
  {
    "name": "header",
    "version": "0.0.4",
    "private": false,
    "location": "/home/ammo/git/lerna-getting-started-example/packages/header",
    "newVersion": "0.0.5"
  },
  {
    "name": "remixapp",
    "version": "0.0.4",
    "private": true,
    "location": "/home/ammo/git/lerna-getting-started-example/packages/remixapp",
    "newVersion": "0.0.5"
  }
]

Motivation and Context

#3720

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@amorscher amorscher marked this pull request as draft October 8, 2023 13:35
@amorscher amorscher force-pushed the feat-version-json branch 2 times, most recently from 666f1d2 to b8039f3 Compare October 8, 2023 18:32
@fahslaj
Copy link
Contributor

fahslaj commented Oct 10, 2023

This is looking good @amorscher !

@amorscher
Copy link
Contributor Author

@fahslaj I just wanted to add some more unit and at least one e2e test.

@amorscher amorscher force-pushed the feat-version-json branch 2 times, most recently from 5aa7664 to f7d0cd8 Compare October 11, 2023 22:44
@amorscher amorscher marked this pull request as ready for review October 11, 2023 22:44
@amorscher
Copy link
Contributor Author

Should be fine now.

@fahslaj fahslaj merged commit 86f22f4 into lerna:main Oct 13, 2023
13 checks passed
@fahslaj
Copy link
Contributor

fahslaj commented Oct 13, 2023

Thanks @amorscher !

@fahslaj fahslaj changed the title feat: add json option to version command feat(version): add json option to version command Oct 14, 2023
@amorscher amorscher deleted the feat-version-json branch October 21, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants