Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): update lock files after the version hook #3849

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

matheo
Copy link
Contributor

@matheo matheo commented Sep 26, 2023

Description

Right now the lock-file is updated before the root version script, but if we edit some custom stuff in that hook (with lerna exec --since then it won't be possible to include those changes in the lock file and that seems undesirable.

How Has This Been Tested?

Tested locally with a custom hook updating the package.json files of the changed packages.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@matheo
Copy link
Contributor Author

matheo commented Sep 26, 2023

@fahslaj the CI failed in a non-related test it seems 🤔

@fahslaj
Copy link
Contributor

fahslaj commented Oct 10, 2023

Thanks @matheo !

@fahslaj fahslaj merged commit 7e30a31 into lerna:main Oct 10, 2023
13 checks passed
@matheo
Copy link
Contributor Author

matheo commented Oct 11, 2023

Thanks @fahslaj any ETA for the release?

@matheo matheo deleted the fix-root-version-hook branch October 11, 2023 15:46
@fahslaj
Copy link
Contributor

fahslaj commented Oct 14, 2023

No specific ETA yet, but we are working on a minor release that will hopefully be out early this coming week.

@fahslaj
Copy link
Contributor

fahslaj commented Oct 17, 2023

@matheo this was just released with version 7.4.0

@matheo
Copy link
Contributor Author

matheo commented Oct 19, 2023

@fahslaj Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants