fix(core): skip unnecessary cycles when running tasks #3834
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Skip unnecessary cycles when running tasks.
Motivation and Context
Without this, the
runProjectsTopologically
function can get "stuck" when there are cycles. It could pick a cycle that doesn't have any projects to run, causing it to exit without running all tasks. See #3798How Has This Been Tested?
This has been covered by unit tests.
Types of changes
Checklist: