Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): skip unnecessary cycles when running tasks #3834

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Sep 8, 2023

Description

Skip unnecessary cycles when running tasks.

Motivation and Context

Without this, the runProjectsTopologically function can get "stuck" when there are cycles. It could pick a cycle that doesn't have any projects to run, causing it to exit without running all tasks. See #3798

How Has This Been Tested?

This has been covered by unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj marked this pull request as ready for review September 8, 2023 19:41
@JamesHenry JamesHenry merged commit d477529 into lerna:main Sep 11, 2023
13 checks passed
@JamesHenry JamesHenry deleted the fix/cycle-dependencies-3798 branch September 11, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants