-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(version): option to not ignore scripts on lock update #3823
Conversation
@fahslaj here a new small one |
Hi @matheo , I think something like |
316aec2
to
80518be
Compare
@fahslaj haha, the commit name was clearer indeed! thanks for the feedback! |
@@ -1703,6 +1706,10 @@ | |||
"type": "boolean", | |||
"description": "During `lerna version`, when true, commit and tag version changes." | |||
}, | |||
"runScriptsOnLockfileUpdate": { | |||
"type": "boolean", | |||
"description": "During `lerna version`, when true, updates the lock file running the lifecycle scripts after the version bump." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please clarify this description a bit? "updates the lock file running the lifecycle scripts" is unclear. Maybe something like ... when true, runs lifecycle scripts when syncing the lock file after the version bump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
80518be
to
5f7c1dc
Compare
5f7c1dc
to
d391d3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @matheo !
@fahslaj thanks! |
@matheo Lerna 7.3.0 was just released and it includes these changes. Thank you! |
Description
Option to not pass
--ignore-scripts
while updating the lock file after the version bump.Motivation and Context
Currently I'm using the old
lerna bootstrap
and I noticed that when versioning/publishing the npm lock file gets incomplete aslerna version
is ignoring the scripts by default while updating it.How Has This Been Tested?
I've used
patch-package
to remove this code locally and it works as expected.Types of changes
Checklist: