Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(version): use async functions to support prettier 3+ #3766

Merged
merged 2 commits into from
Jul 10, 2023
Merged

fix(version): use async functions to support prettier 3+ #3766

merged 2 commits into from
Jul 10, 2023

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Jul 6, 2023

Description

Use async functions from prettier in order to support prettier 3+

Motivation and Context

#3765

How Has This Been Tested?

This has been tested manually against workspaces on prettier 2.8.8 and 3.0.0.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj changed the title fix(publish): use async functions to support prettier 3+ fix(version): use async functions to support prettier 3+ Jul 6, 2023
@fahslaj fahslaj mentioned this pull request Jul 7, 2023
Closed
@fahslaj fahslaj marked this pull request as ready for review July 7, 2023 14:58
@fahslaj fahslaj requested a review from JamesHenry July 7, 2023 14:58
@jdalrymple jdalrymple mentioned this pull request Jul 8, 2023
Merged
@chenbimo
Copy link

chenbimo commented Jul 8, 2023

need this.

@fahslaj fahslaj merged commit 8026a7b into lerna:main Jul 10, 2023
13 checks passed
@fahslaj fahslaj deleted the fix/support-prettier-3.0 branch July 10, 2023 18:23
turadg added a commit to endojs/endo that referenced this pull request Jul 18, 2023
@turadg
chore(deps): patch Lerna for Prettier v3 compat
9cc6c2c 
backport of lerna/lerna#3766
@turadg turadg mentioned this pull request Jul 18, 2023
Merged
kriskowal pushed a commit to endojs/endo that referenced this pull request Jul 18, 2023
@turadg @kriskowal
chore(deps): patch Lerna for Prettier v3 compat
82f4881 
backport of lerna/lerna#3766
@BenoitZugmeyer BenoitZugmeyer mentioned this pull request Jul 27, 2023
Merged
10 tasks
@jzempel jzempel mentioned this pull request Aug 4, 2023
Merged
4 tasks
@veinfors veinfors mentioned this pull request Sep 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fahslaj @chenbimo @JamesHenry