Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix strict-ssl mapping for node-fetch-registry during unpublished projects lookup #3747

Merged
merged 4 commits into from
Jun 27, 2023

Conversation

CSchulz
Copy link
Contributor

@CSchulz CSchulz commented Jun 23, 2023

fixes #3746

Description

There is a missing mapping of strict-ssl for unpublished projects lookup.
This results into falsy unpublished projects.

Motivation and Context

We are using lerna to automatically determine which packages are unpublished. We have encountered the issue it tries to publish packages again and again regardless if they are already published.
With debugging I have found out there is an issue using the given strict-ssl attribute. It is not passed to pacote correctly.

In general it is the same issue like here #2952

How Has This Been Tested?

I have debugged everything and also tried to write an unit test which should cover this scenario.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
    • there are some tests failing (perhaps of my Windows environment)

Sorry, something went wrong.

@nx-cloud
Copy link

nx-cloud bot commented Jun 23, 2023

☁️ Nx Cloud Report

Attention: This version of the Nx Cloud GitHub bot will cease to function on July 1st, 2023. An organization admin can update your integration here.

We didn't find any information for the current pull request with the commit a21415a.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@JamesHenry
Copy link
Member

Thanks @CSchulz, please run npm run format:write and commit the results, the formatting check is currently failing

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JamesHenry JamesHenry merged commit 5fcf94e into lerna:main Jun 27, 2023
@CSchulz CSchulz deleted the fix/registry-fetch-strict-ssl-false branch September 12, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lerna doest not respect strict-ssl=false in .npmrc for registry lookup
3 participants