New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolving rimraf bin dir #3614
Conversation
Nx Cloud ReportCI is running for commit 1578725. 📂 Click to track the progress, see the status, the terminal output, and the build insights. Sent with 💌 from NxCloud. |
Thanks @tada5hi one small change then this LGTM! |
Thanks again! |
Sadly this didn't actually solve the problem because the bin path is not part of the package's exports and so node blocks it, I am looking into refactoring the whole approach here, I believe we can just use the node API of rimraf instead of all these child process + bin shenanigans |
damm ... i think the problem is, that i missed to join the And it should be |
Description
Due to the fact that rimraf has changed its binary path, lerna no longer works with the new version 4.4.x. Therefore the cli location is now read from the package.json, as fallback the original module resolving was used.
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist:
fixes #3614