Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publish): use updated version with pnpm workspaces #3606

Merged

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Mar 23, 2023

Description

Correctly use the updated version of a dependency that is updated during lerna publish.

Motivation and Context

#3456

How Has This Been Tested?

This has been tested manually against a repro workspace. All existing tests pass.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj marked this pull request as ready for review March 23, 2023 18:44
@JamesHenry JamesHenry merged commit cd7ad21 into lerna:main Mar 24, 2023
13 checks passed
@fahslaj fahslaj deleted the fix/3456-use-new-version-with-pnpm-workspaces branch March 24, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants