Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle trailing commas and comments in lerna.json files #3603

Merged

Conversation

JamesHenry
Copy link
Member

Currently lerna will hard error if trailing commas and/or comments are present in lerna.json files. This PR changes that and allows it to continue in these cases. It will still hard error if there is any other kind of JSON parsing error.

Closes #2423

@JamesHenry JamesHenry marked this pull request as ready for review March 23, 2023 12:18
@JamesHenry JamesHenry merged commit b826398 into main Mar 23, 2023
13 checks passed
@JamesHenry JamesHenry deleted the do-not-error-on-trailing-commas-and-comments-in-lerna-json branch March 23, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use JSON5 or another parser with support for comments for config-files
1 participant