Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps) : update arborist package to get rid of deprecated warning #3559

Merged
merged 3 commits into from Mar 8, 2023

Conversation

amorscher
Copy link
Contributor

@amorscher amorscher commented Feb 26, 2023

Partially fixes #3550

Description

Updates to the actual version of npmcli/arborist which causes following deprecation warning to disappear.

npm WARN deprecated readdir-scoped-modules@1.1.0: This functionality has been moved to @npmcli/fs

Motivation and Context

Partially fixes #3550

How Has This Been Tested?

Existing unit, integration and e2e tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@amorscher amorscher marked this pull request as draft February 26, 2023 22:23
@amorscher
Copy link
Contributor Author

@JamesHenry @fahslaj eslint is complaining. Can I add the failure to the esignore patterns

@JamesHenry
Copy link
Member

@amorscher The lint error is occurring within a file nested within lerna/node_modules, which should not exist at all. So that has been introduced by this change and needs to be resolved before proceeding

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@amorscher amorscher marked this pull request as ready for review March 5, 2023 06:51
@amorscher
Copy link
Contributor Author

amorscher commented Mar 5, 2023

@JamesHenry so I also updated dependant packages of arborist so that all modules are hoisted.

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @amorscher!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installing lerna shows two deprecated warnings for used module functionality
2 participants