Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): update yarn lock for versions of yarn >= 2.0.0 #3555

Merged
merged 2 commits into from Feb 24, 2023

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Feb 22, 2023

Description

Updates yarn.lock after lerna version when on a version of yarn >= 2.0.0.

Yarn versions before 2.0.0 (all non-berry releases) don't put workspace dependencies in the lock file, so they do not need to be updated.

Motivation and Context

#3551

How Has This Been Tested?

This has been tested manually and covered by an e2e test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj force-pushed the fix/3551-update-yarn-lock branch 10 times, most recently from cfa4191 to 53e564b Compare February 23, 2023 19:29
@fahslaj fahslaj marked this pull request as ready for review February 23, 2023 20:33
@JamesHenry JamesHenry merged commit ce2ceca into lerna:main Feb 24, 2023
@fahslaj fahslaj deleted the fix/3551-update-yarn-lock branch February 24, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants