Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(version): handle deps property missing due to outdated lockfile #3549

Merged

Conversation

fahslaj
Copy link
Contributor

@fahslaj fahslaj commented Feb 16, 2023

Description

Handles the case that the dependencies or devDependencies property is not defined in package.json, but does exist in package-lock.json.

Motivation and Context

This case should only happen if the package.json file is updated and npm install is not run afterwards to update the lockfile. However, now Lerna will handle this case gracefully.

#3546

How Has This Been Tested?

This has been tested manually and covered by a new unit test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (change that has absolutely no effect on users)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@fahslaj fahslaj self-assigned this Feb 16, 2023
@fahslaj fahslaj marked this pull request as ready for review February 16, 2023 20:01
@JamesHenry JamesHenry merged commit fdbbab9 into lerna:main Feb 17, 2023
@fahslaj fahslaj deleted the fix/3546-handle-outdated-package-lock branch February 17, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants