fix(publish): ensure zero exit code when EWORKINGTREE warning occurs

[paul-leo]

fixed error when run "lerna publish from-package" in package.json scripts

Description

when verifyWorkingTreeClean error happend set exitCode to 0

Motivation and Context

How Has This Been Tested?

1、add publish:'lerna publish from-package" to package.json->"scripts"
2、exec "npm run publish" in terminal
3、everything well done

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (change that has absolutely no effect on users)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[paul-leo]

fixed

[sirctseb]

@juristr we recently upgraded from version 3.22.1 to version 6. When using lerna publish from-package --no-git-reset, we get the issue described here: the publish succeeds, but the process exit code is 128, so our build containers are marked as failures.

Some more context:

1. The issue occurs when there is no .git directory (as it the case in CI, since we don't include the .git directory in the image), and can be reproduced locally by simply removing or renaming the .git directory
2. The issue is introduced in version 4.0.0. Version 3.22.1 works just fine. There are a lot of commits in that release, I haven't found a way to git bisect because I can't yarn link lerna directly into my project, and I haven't identified any suspicious changes in the publish implementation that would explain it, however:
3. the change in this PR resolves our problem, although it is not clear why (in particular, it is not clear why it wasn't a problem in 3.22.1)

Do you think this PR should be accepted?

[juristr]

@sirctseb I'll bring this issue to the team's attention so we can look into it. There are a couple of potential issues we've already seen that might occur when there's no Git repo set up because Lerna requires Git for many of its operations. Some are legit because the Git information is needed as part of the operation, but for others it should not be required.

[sirctseb]

Thanks @juristr. Let me know if we can help with any additional information from our use-case. We do not need (or want) our .git directory in the docker image we us in CI when we call lerna publish from-package and my understanding is that that operation does not require any knowledge of git for that operation, with evidence from the fact that version 3 worked with no issue and this message from the code:

this.logger.notice("FYI", "Unable to verify working tree, proceed at your own risk");

We're exploring workarounds like using patch-package to include the change from this PR in our local installation, but would rather get correct working behavior back into your repo.

Thanks!

[JamesHenry]

Thank you @pengzai-dev!

[Cabeda]

Is there an estimated date for a new release with this fix?

[JamesHenry]

Thanks for your patience on this, it slipped my mind completely - we will cut a release this week for sure

[JamesHenry]

Lerna 6.6.0 is now available which includes this, many thanks!