Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow falsey but non-None grant uri params #544

Merged
merged 1 commit into from Jun 7, 2023

Conversation

schnerd
Copy link
Contributor

@schnerd schnerd commented Apr 23, 2023

There are use cases where you want to pass 0 to authorize_redirect, for example Auth0 allows you to force login again by passing max_age=0, as described here.

The current code for prepare_grant_uri filters out such parameters. This PR changes that to explicitly filter out None instead.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

Debatable? Technically a breaking change if someone was passing a non-None falsey value to authorize_redirect() previously.


  • You consent that the copyright of your pull request source code belongs to Authlib's author.

@lepture lepture merged commit cadc55d into lepture:master Jun 7, 2023
1 check passed
@lepture
Copy link
Owner

lepture commented Jun 7, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants