Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erigon misreports Tx Size on eth/68 #8456

Closed
MariusVanDerWijden opened this issue Oct 12, 2023 · 1 comment · Fixed by #8502
Closed

Erigon misreports Tx Size on eth/68 #8456

MariusVanDerWijden opened this issue Oct 12, 2023 · 1 comment · Fixed by #8502
Assignees
@yperbasis

Comments

@MariusVanDerWijden
Copy link
Contributor

It looks like erigon nodes are always claiming 1 or two bytes less than they are actually sending. Most likely missing the txtype bytes. See also ethereum/go-ethereum#28261
@MariusVanDerWijden MariusVanDerWijden mentioned this issue Oct 12, 2023
Merged
@karalabe
Copy link
Contributor

This is very annoying, please fix. Or we can just start dropping Erigon peers for protocol violation. Either works for me really.

@yperbasis yperbasis linked a pull request Oct 17, 2023 that will close this issue
eth/68: always announce tx sizes with envelopes #8502
Merged
@yperbasis yperbasis reopened this Oct 19, 2023
@yperbasis yperbasis self-assigned this Oct 19, 2023
@yperbasis yperbasis mentioned this issue Oct 19, 2023
Merged
yperbasis added a commit that referenced this issue Oct 19, 2023
@yperbasis
eth/68: always announce tx sizes without envelopes (#8530)
5dd311c 
It turns out that Marius got it the other way round in Issue #8456. See
https://discord.com/channels/595666850260713488/1162151688816308245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yperbasis yperbasis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

eth/68: always announce tx sizes with envelopes ledgerwatch/erigon
3 participants
@karalabe @MariusVanDerWijden @yperbasis