README.md

@@ -43,6 +43,25 @@ client on your system:
 
     npm install ldapjs
 
+## Node.js Version Support
+
+As of `ldapjs@3` we only support the active Node.js LTS releases.
+See [https://github.com/nodejs/release#release-schedule][schedule] for the LTS
+release schedule.
+
+For a definitive list of Node.js version we support, see the version matrix
+we test against in our [CI configuration][ci-config].
+
+Note: given the release date of `ldapjs@3`, and the short window of time that
+Node.js v14 had remaining on its LTS window, we opted to not support Node.js
+v14 with `ldapjs@3` (we released late February 2023 and v14 goes into
+maintenance in late April 2023). Also, Node.js v14 will be end-of-life (EOL) on
+September 11, 2023; this is a very shortened EOL timeline and makes it even
+more reasonable to not support it at this point.
+
+[schedule]: https://github.com/nodejs/release#release-schedule
+[ci-config]: https://github.com/ldapjs/node-ldapjs/blob/master/.github/workflows/main.yml
+
 ## License
 
 MIT.

docs/client.md

@@ -308,7 +308,7 @@ client.search('o=example', opts, (err, res) => {
     console.log('searchRequest: ', searchRequest.messageId);
   });
   res.on('searchEntry', (entry) => {
-    console.log('entry: ' + JSON.stringify(entry.object));
+    console.log('entry: ' + JSON.stringify(entry.pojo));
   });
   res.on('searchReference', (referral) => {
     console.log('referral: ' + referral.uris.join());

package.json

@@ -3,7 +3,7 @@
   "name": "ldapjs",
   "homepage": "http://ldapjs.org",
   "description": "LDAP client and server APIs",
-  "version": "3.0.0",
+  "version": "3.0.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -17,7 +17,7 @@
     "@ldapjs/controls": "2.0.0",
     "@ldapjs/dn": "1.0.0",
     "@ldapjs/filter": "2.0.0",
-    "@ldapjs/messages": "1.0.0",
+    "@ldapjs/messages": "1.0.1",
     "@ldapjs/protocol": "^1.2.1",
     "abstract-logging": "^2.0.1",
     "assert-plus": "^1.0.0",
@@ -28,7 +28,7 @@
   },
   "devDependencies": {
     "@fastify/pre-commit": "^2.0.2",
-    "eslint": "8.34.0",
+    "eslint": "8.35.0",
     "eslint-config-standard": "^17.0.0",
     "eslint-plugin-import": "^2.27.5",
     "eslint-plugin-n": "^15.6.1",

test/issue-845.test.js

@@ -0,0 +1,116 @@
+'use strict'
+
+const tap = require('tap')
+const { SearchResultEntry, SearchRequest } = require('@ldapjs/messages')
+const ldapjs = require('../')
+
+const server = ldapjs.createServer()
+
+const SUFFIX = ''
+const directory = {
+  'dc=example,dc=com': {
+    objectclass: 'example',
+    dc: 'example',
+    cn: 'example'
+  }
+}
+
+server.bind(SUFFIX, (req, res, done) => {
+  res.end()
+  return done()
+})
+
+server.search(SUFFIX, (req, res, done) => {
+  const dn = req.dn.toString().toLowerCase()
+
+  if (Object.hasOwn(directory, dn) === false) {
+    return done(Error('not in directory'))
+  }
+
+  switch (req.scope) {
+    case SearchRequest.SCOPE_BASE:
+    case SearchRequest.SCOPE_SUBTREE: {
+      res.send(new SearchResultEntry({ objectName: `dc=${req.scopeName}` }))
+      break
+    }
+  }
+
+  res.end()
+  done()
+})
+
+tap.beforeEach(t => {
+  return new Promise((resolve, reject) => {
+    server.listen(0, '127.0.0.1', (err) => {
+      if (err) return reject(err)
+      t.context.url = server.url
+
+      t.context.client = ldapjs.createClient({ url: [server.url] })
+      t.context.searchOpts = {
+        filter: '(&(objectClass=*))',
+        scope: 'sub',
+        attributes: ['dn', 'cn']
+      }
+
+      resolve()
+    })
+  })
+})
+
+tap.afterEach(t => {
+  return new Promise((resolve, reject) => {
+    t.context.client.destroy()
+    server.close((err) => {
+      if (err) return reject(err)
+      resolve()
+    })
+  })
+})
+
+tap.test('rejects if search not in directory', t => {
+  const { client, searchOpts } = t.context
+
+  client.search('dc=nope', searchOpts, (err, res) => {
+    t.error(err)
+    res.on('error', err => {
+      // TODO: plain error messages should not be lost
+      // This should be fixed in a revamp of the server code.
+      // ~ jsumners 2023-03-08
+      t.equal(err.lde_message, 'Operations Error')
+      t.end()
+    })
+  })
+})
+
+tap.test('base scope matches', t => {
+  const { client, searchOpts } = t.context
+  searchOpts.scope = 'base'
+
+  client.search('dc=example,dc=com', searchOpts, (err, res) => {
+    t.error(err)
+    res.on('error', (err) => {
+      t.error(err)
+      t.end()
+    })
+    res.on('searchEntry', entry => {
+      t.equal(entry.objectName.toString(), 'dc=base')
+      t.end()
+    })
+  })
+})
+
+tap.test('sub scope matches', t => {
+  const { client, searchOpts } = t.context
+
+  client.search('dc=example,dc=com', searchOpts, (err, res) => {
+    t.error(err)
+    res.on('error', (err) => {
+      t.error(err)
+      t.end()
+    })
+    res.on('searchEntry', entry => {
+      t.equal(entry.objectName.toString(), 'dc=subtree')
+      t.end()
+    })
+  })
+})