.eslintrc.js

@@ -4,6 +4,9 @@ module.exports = {
     es2021: true,
     node: true
   },
+  parserOptions: {
+    ecmaVersion: 'latest'
+  },
   extends: [
     'standard'
   ],

.github/workflows/docs.yml

@@ -13,7 +13,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: '14'
+          node-version: '18'
       - name: Install Packages
         run: npm install
       - name: Build Docs

.github/workflows/integration.yml

@@ -4,9 +4,14 @@ name: 'Integration Tests'
 #  https://github.community/t5/GitHub-Actions/Github-Actions-services-not-reachable/m-p/30739/highlight/true#M538
 
 on:
+  push:
+    branches:
+      - master
+      - next
   pull_request:
     branches:
       - master
+      - next
 
 jobs:
   baseline:

.github/workflows/main.yml

@@ -4,9 +4,11 @@ on:
   push:
     branches:
       - master
+      - next
   pull_request:
     branches:
       - master
+      - next
 
 jobs:
   lint:
@@ -15,6 +17,8 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
+        with:
+          node-version: 'lts/*'
       - name: Install Packages
         run: npm install
       - name: Lint Code
@@ -28,10 +32,9 @@ jobs:
           - ubuntu-latest
           - windows-latest
         node:
-          - 10.13.0
-          - 10.x
-          - 12.x
-          - 14.x
+          - 16
+          - 18
+          - 19
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3
@@ -42,13 +45,3 @@ jobs:
         run: npm install
       - name: Run Tests
         run: npm run test:ci
-      - name: Coveralls Parallel
-        uses: coverallsapp/github-action@1.1.3
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          parallel: true
-      - name: Coveralls Finished
-        uses: coverallsapp/github-action@1.1.3
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          parallel-finished: true

.npmrc

@@ -0,0 +1,3 @@
+# npm general settings
+package-lock=false
+legacy-peer-deps=true

.taprc.yml

@@ -0,0 +1,10 @@
+# With PR #834 the code in this code base has been reduced significantly.
+# As a result, the coverage percentages changed, and are much lower than
+# previously. So we are reducing the requirements accordingly
+branches: 50
+functions: 50
+lines: 50
+statements: 50
+
+files:
+  - 'test/**/*.test.js'

README.md

@@ -43,8 +43,6 @@ client on your system:
 
     npm install ldapjs
 
-DTrace support is included in ldapjs. To enable it, `npm install dtrace-provider`.
-
 ## License
 
 MIT.

docs/client.md

@@ -22,7 +22,7 @@ const client = ldap.createClient({
   url: ['ldap://127.0.0.1:1389', 'ldap://127.0.0.2:1389']
 });
 
-client.on('error', (err) => {
+client.on('connectError', (err) => {
   // handle connection error
 })
 ```
@@ -41,7 +41,6 @@ client is:
 |connectTimeout |Milliseconds client should wait before timing out on TCP connections (Default: OS default)|
 |tlsOptions     |Additional options passed to TLS connection layer when connecting via `ldaps://` (See: The TLS docs for node.js)|
 |idleTimeout    |Milliseconds after last activity before client emits idle event|
-|strictDN       |Force strict DN parsing for client methods (Default is true)|
 |reconnect      |Try to reconnect when the connection gets lost (Default is false)|
 
 ### url
@@ -287,7 +286,7 @@ Responses inside callback of the `search` method are an `EventEmitter` where you
 each `searchEntry` that comes back from the server. You will additionally be able to listen for a `searchRequest`
 , `searchReference`, `error` and `end` event.
 `searchRequest` is emitted immediately after every `SearchRequest` is sent with a `SearchRequest` parameter. You can do operations
-like `client.abandon` with `searchRequest.messageID` to abandon this search request. Note that the `error` event will
+like `client.abandon` with `searchRequest.messageId` to abandon this search request. Note that the `error` event will
 only be for client/TCP errors, not LDAP error codes like the other APIs. You'll want to check the LDAP status code
 (likely for `0`) on the `end` event to assert success. LDAP search results can give you a lot of status codes, such as
 time or size exceeded, busy, inappropriate matching, etc., which is why this method doesn't try to wrap up the code
@@ -306,7 +305,7 @@ client.search('o=example', opts, (err, res) => {
   assert.ifError(err);
 
   res.on('searchRequest', (searchRequest) => {
-    console.log('searchRequest: ', searchRequest.messageID);
+    console.log('searchRequest: ', searchRequest.messageId);
   });
   res.on('searchEntry', (entry) => {
     console.log('entry: ' + JSON.stringify(entry.object));

docs/server.md

@@ -80,8 +80,15 @@ Example:
 `listen(port, [host], [callback])`
 
 Begin accepting connections on the specified port and host. If the host is
-omitted, the server will accept connections directed to any IPv4 address
-(INADDR\_ANY).
+omitted, the server will accept connections directed to the IPv4 address
+`127.0.0.1`. To listen on any other address, supply said address as the `host`
+parameter. For example, to listen on all available IPv6 addresses supply
+`::` as the `host` (note, this _may_ also result in listening on all
+available IPv4 addresses, depending on operating system behavior).
+
+We highly recommend being as explicit as possible with the `host` parameter.
+Listening on all available addresses (through `::` or `0.0.0.0`) can lead
+to potential security issues.
 
 This function is asynchronous. The last parameter callback will be called when
 the server has been bound.
@@ -197,7 +204,7 @@ authenticated as on this connection. If the client didn't bind, then a DN object
 will be there defaulted to `cn=anonymous`.
 
 Additionally, request will have a `logId` parameter you can use to uniquely
-identify the request/connection pair in logs (includes the LDAP messageID).
+identify the request/connection pair in logs (includes the LDAP messageId).
 
 ## Common Response Elements
 

examples/inmemory.js

@@ -130,7 +130,7 @@ server.search(SUFFIX, authorize, function (req, res, next) {
     case 'base':
       if (req.filter.matches(db[dn])) {
         res.send({
-          dn: dn,
+          dn,
           attributes: db[dn]
         })
       }