Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add components and relationships count in model response #607

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

Yashsharma1911
Copy link
Contributor

@Yashsharma1911 Yashsharma1911 commented Oct 14, 2024

Description

This PR fixes #

This PR updates meshmodel API response to include component count and relationship count and implement feature for trim param (if true API will send only necessary data)

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Sorry, something went wrong.

Signed-off-by: Yash Sharma <yashsharma2572@gmail.com>
@Yashsharma1911
Copy link
Contributor Author

This PR depends on new release of schemas repo

@Yashsharma1911
Copy link
Contributor Author

lint will pass as we will make release of schemas repo

@leecalcote
Copy link
Member

lint will pass as we will make release of schemas repo

@Yashsharma1911 Ok. Let's do it. ✅

Select("relationship_definition_dbs.*").
Where("relationship_definition_dbs.model_id = ?", _modelDB.Id)
if err := finder.Scan(&relationships).Error; err != nil {
return nil, 0, 0, err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jougan-0 look good?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

Signed-off-by: Yash Sharma <yashsharma2572@gmail.com>
@Yashsharma1911 Yashsharma1911 merged commit 05d562e into meshery:master Oct 15, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants