Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme #321

Merged
merged 8 commits into from
Jun 8, 2023
Merged

Readme #321

merged 8 commits into from
Jun 8, 2023

Conversation

Philip-21
Copy link
Member

@Philip-21 Philip-21 commented Jun 1, 2023

Description

This PR fixes #
Pull Request for Utils package Documentation #286
Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Sorry, something went wrong.

Philip-21 and others added 5 commits April 19, 2023 15:55
Signed-off-by: Philip Obiora <73377830+Philip-21@users.noreply.github.com>
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
Copy link
Member Author

Philip-21 commented Jun 1, 2023

@leecalcote i was able to take some time yesterday to go through the utils package and make some documentation on some packages . You can look through it and tell me what you think , i am still going to add more descriptions for other packages.

@leecalcote leecalcote requested review from Aisuko and nebula-aac June 1, 2023 17:45
utils/readme.md Outdated
Here is a brief description of some of the packages embedded in Utils:


### Kuberentes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this line work well? Why add a blank before it?

Copy link
Member Author

@Philip-21 Philip-21 Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The aspects where i left spaces are where i will add descriptions for other packages , i just pushed this pr for reviews on the descriptions i've made.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I got your point, but please follow the syntax of markdown.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright ,
from this commit i just pushed i think i have made adjustment to the spaces .

utils/readme.md Outdated
Overall, the describe package provides a convenient way to retrieve detailed information about Kubernetes resources in a standardized format.


##### Expose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

utils/readme.md Outdated
- The <code>Expose()</code> is the main function of the package this takes a Kubernetes clientset, REST config, Config object, and a list of resources to expose.
- It uses a Traverser to iterate over the resources and generate the corresponding services.
Overall, this package provides a way to expose Kubernetes resources as services with customizable configurations.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why there are so many blanks here?

Philip-21 added 3 commits June 2, 2023 07:51
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
Signed-off-by: Philip-21 <philipuzomaobiora@gmail.com>
@Philip-21
Copy link
Member Author

@Aisuko i have made adjustments on the spaces and blanks .
This is all i could come up with for the docs of the utils package.

Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Philip-21 💪

@leecalcote leecalcote merged commit f605059 into meshery:master Jun 8, 2023
@Philip-21
Copy link
Member Author

@Philip-21 💪

Thanks @leecalcote

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants