Layer5 welcome logo changed to Meshery logos with dark and light them… #308
Conversation
…e preference Signed-off-by: om2137 <omraut961@gmail.com>
|
Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Community Welcome Guide and sure to join the community Slack. |
There was a problem hiding this comment.
It is recommended to use SVG logos with uniform name conventions
meshery-celebration-dark.svg
meshery-celebration-light.svg
For reference kindly look at the approved or closed PRs handling this issue.
Co-authored-by: Karan Thakur <karanthakur.work@gmail.com> Signed-off-by: Lee Calcote <leecalcote@gmail.com>
There was a problem hiding this comment.
@anshgoyalevil, please assist @om2137 by correcting the instructions offered in the corresponding issue.
.github/config.yml
Outdated
| <picture> | ||
| <source media="(prefers-color-scheme: dark)" srcset="./welcome/Meshery-celebration-w.png"> | ||
| <source media="(prefers-color-scheme: light)" srcset="./welcome/Meshery-celebration-b.png"> | ||
| <img alt="Shows a black logo in light color mode and a white one in dark color mode." src="https://user-images.githubusercontent.com/25423296/163456779-a8556205-d0a5-45e2-ac17-42d089e3c3f8.png"> | ||
| </picture> |
There was a problem hiding this comment.
Thanks for the changes @om2137 🛩️
There are some changes required.
- The
srcsetneeds to be a reference to absolute path to raw image. - The name of the images needs to be more clear, as explained by @thisiskaransgit
- Also, I think, you have interchanged the white image to dark color scheme, and black to light color scheme.
Please refer to the following example
Thanks for your contribution to Meshery! :tada:
<picture>
<source media="(prefers-color-scheme: dark)" srcset="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/Meshery-celebration-Dark.svg">
<source media="(prefers-color-scheme: light)" srcset="https://raw.githubusercontent.com/meshery/meshery/master/.github/assets/images/Meshery-celebration-Light.svg">
<img alt="Meshery Logo" src="">
</picture>
Or, Following Merged PR, referring to a similar issue - https://github.com/meshery/meshery/pull/7586/files
There was a problem hiding this comment.
@anshgoyalevil @om2137 we prefer SVG over PNG... Could we use SVGs here of the exact same name and location as the rest of the repos?
|
@om2137 are you still working on the issue? |
|
@om2137 Are you still working on the issue? Feel free to ping me here or on slack if you are facing any issues. |
Hey extremely sorry, I didn't get the notification for this. If you want you can take this |
|
@om2137 Alright 😅 Would you like to close this PR? |
Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
|
Thanks for your contribution to Meshery! 🎉 
|
Description
Replace the Logo of Layer5 with Meshery in the config.yml workflow
This PR fixes #296 also #295
Notes for Reviewers
Signed commits