Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove &mut PoolConnection from Executor docs #2695

Merged
merged 1 commit into from Sep 12, 2023

Conversation

olback
Copy link
Contributor

@olback olback commented Aug 15, 2023

As per the Changelog for the 0.7.0 release:

The Executor impls for Transaction and PoolConnection have been deleted because they cannot exist in the new crate architecture without rewriting the Executor trait entirely.

@olback
Copy link
Contributor Author

olback commented Aug 31, 2023

The failing CI fmt check isn't due to any of my changes, should I fix it anyway?

@abonander abonander merged commit 2e4533e into launchbadge:main Sep 12, 2023
57 of 58 checks passed
@ShayBox
Copy link

ShayBox commented Mar 22, 2024

How do I fix this in my code? I use conn: &mut PoolConnection<MySql> everywhere in my library which has to work with sqlx and rocket_db_pools. I can't seem to use &Pool, MySqlConnection, or AnyConnection.

@abonander
Copy link
Collaborator

Dereference the PoolConnection: &mut *conn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants