Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variables naming convention #327

Closed
peppelinux opened this issue Aug 15, 2023 · 2 comments · Fixed by #330
Closed

variables naming convention #327

peppelinux opened this issue Aug 15, 2023 · 2 comments · Fixed by #330

Comments

@peppelinux
Copy link
Contributor

It would be better to not use a or c for var assignment, they collides (then overloads) with pdb commands, as also s, unt and so on

[11] > /home/wert/DEV/IdentityPython/satosa-saml2spid/env/lib/python3.10/site-packages/jwcrypto/jws.py(287)_verify()
-> a = p['alg']
(Pdb++) 
[11] > DEV/IdentityPython/satosa-saml2spid/env/lib/python3.10/site-packages/jwcrypto/jws.py(291)_verify()
-> if isinstance(key, JWK):
(Pdb++) key
{"kid":"OXk3T3ZhdGw0QmxLRXc4bUJDd0gtOFJENURfek9DZVdWNHlQeUppbW13SQ","thumbprint":"9y7Ovatl4BlKEw8mBCwH-8RD5D_zOCeWV4yPyJimmwI"}
(Pdb++) n
[11] > DEV/IdentityPython/satosa-saml2spid/env/lib/python3.10/site-packages/jwcrypto/jws.py(292)_verify()
-> c = JWSCore(a, key, protected, payload, self._allowed_algs)
(Pdb++) 
[11] > DEV/IdentityPython/satosa-saml2spid/env/lib/python3.10/site-packages/jwcrypto/jws.py(293)_verify()
-> c.verify(signature)
(Pdb++) 
@simo5
Copy link
Member

simo5 commented Aug 21, 2023

Patch welcome to rename those variables.

@peppelinux
Copy link
Contributor Author

Happy to help!
Here my contribution #330
pleased for having this opportunity,
best

@simo5 simo5 closed this as completed in #330 Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants