New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix open in browser with APP_PORT #663

Merged

taylorotwell merged 2 commits into laravel:1.x from ijpatricio:patch-1

Feb 8, 2024

Contributor

ijpatricio commented Feb 2, 2024

When a env variable for APP_PORT is defined (to something else than 80), then the site won't open correctly on the sail open command.

This PR adds a simple check:

If APP_PORT is set and not to 80, then the FULL_URL gets the port added.
else FULL_URL is set as before

Finally, open FULL_URL.

ijpatricio and others added 2 commits

February 2, 2024 17:00


          Fix open in browser with APP_PORT

d86c3f4


          Update sail

48fddbc

taylorotwell merged commit 3047e1a into laravel:1.x

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment