Fix TypeScript Error in isConstructor
#412
Merged
+6
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a TypeScript error in the
isConstructor
utility function and improves error handling for enhanced type safety.Key Changes
TypeScript Error Fix:
TS18046: 'err' is of type 'unknown'
error by explicitly checking whether the caughterr
is an instance ofError
before accessing itsmessage
.Improved Error Handling:
catch
block to specifically handle cases whereobj
is not a valid constructor by checking the error message for "is not a constructor."unknown
instead ofany
unknown
instead ofany
aligns with TypeScript best practices by forcing developers to explicitly assert or narrow types, reducing potential runtime errors.TS error
TS18046
only happens when running TS in strict, so in theEcho
project itself you don't see it until enablingstrict
, but our TS config falls over this library implementation, and the change is a net benefit IMO.