Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: document model relationships #1905

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Conversation

calebdw
Copy link
Contributor

@calebdw calebdw commented Apr 6, 2024

  • Documented user facing changes

Related to #1902

Hello!

This documents that model relationships must be public and have their return type defined to be recognized as a relationship to help avoid future confusion.

Thanks!

@szepeviktor
Copy link
Collaborator

szepeviktor commented Apr 6, 2024

The hidden knowledge of Larastan is vast.

e.g. the parameter of belongsTo needs to be a literal string

A hardcore Larastan user must be a (source code reading) contributor too. That is a fact.

@calebdw
Copy link
Contributor Author

calebdw commented Apr 6, 2024

Ah yes, I'll add that in there!

@szepeviktor
Copy link
Collaborator

Ah yes, I'll add that in there!

Now we have "only" 4999 secrets 🙃

docs/features.md Outdated Show resolved Hide resolved
@calebdw
Copy link
Contributor Author

calebdw commented Apr 11, 2024

Cool new profile pic @szepeviktor!

Does this look good enough to merge?

docs/features.md Outdated Show resolved Hide resolved
docs/features.md Outdated Show resolved Hide resolved
@canvural canvural merged commit 320bcf0 into larastan:2.x Apr 14, 2024
1 check passed
@canvural
Copy link
Collaborator

Thank you!

@calebdw calebdw deleted the relation_doc branch April 14, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants