Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use matplotlib's agg backend in test_figure.py. #706

Merged
merged 1 commit into from
Jul 16, 2023
Merged

Use matplotlib's agg backend in test_figure.py. #706

merged 1 commit into from
Jul 16, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Jul 12, 2023

By default, matplotlib will use an interactive backend when it detects that one is available. This is both unnecessary and, in some cases, can break builds.

One example of a build breaking is on macOS Ventura when these tests are run using a non-root user (such as a user used for builds) that is not the logged-in user. The interactive macOS backend crashes with an error in _xpc_api_misuse when creating an NSWindow, likely due to some tighter security requirements.

By default, matplotlib will use an interactive backend when it detects
that one is available. This is both unnecessary and, in some cases, can
break builds.

One example of a build breaking is on macOS Ventura when these tests
are run using a non-root user (such as a user used for builds) that is
not the logged-in user. The interactive macOS backend crashes with an
error in _xpc_api_misuse when creating an NSWindow, likely due to some
tighter security requirements.
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.04 🎉

Comparison is base (d75a89b) 84.75% compared to head (751821c) 84.79%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #706      +/-   ##
==========================================
+ Coverage   84.75%   84.79%   +0.04%     
==========================================
  Files          36       36              
  Lines        2105     2105              
==========================================
+ Hits         1784     1785       +1     
+ Misses        321      320       -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lanpa
Copy link
Owner

lanpa commented Jul 16, 2023

Thanks!

@lanpa lanpa merged commit 9adc9f6 into lanpa:master Jul 16, 2023
@tjni tjni deleted the test-matplotlib-agg branch July 16, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants