Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: read llm node's first prompt role by optional chaining #4510

Merged
merged 1 commit into from
May 20, 2024

Conversation

sinomoe
Copy link
Contributor

@sinomoe sinomoe commented May 19, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #4509

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 🐞 bug Something isn't working labels May 19, 2024
@bowenliang123
Copy link
Contributor

Could you explain some more about how it fixes the issue?

@sinomoe
Copy link
Contributor Author

sinomoe commented May 19, 2024

Could you explain some more about how it fixes the issue?

this is a newly created chat bot with no prompts.

sceencut-HD.720p.mov

@bowenliang123
Copy link
Contributor

Cool. SGTM.

@takatost takatost requested a review from zxhlyh May 19, 2024 14:45
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 20, 2024
@crazywoola crazywoola merged commit 5440108 into langgenius:main May 20, 2024
7 checks passed
@sinomoe sinomoe deleted the fix/switch-chatbot-mode branch May 20, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to switch chat bot from baisc mode to workflow
3 participants