Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add JiebaLinkExtractor for chinese doc extracting #30150

Merged

Conversation

andyzhou1982
Copy link
Contributor

@andyzhou1982 andyzhou1982 commented Mar 7, 2025

Thank you for contributing to LangChain!

  • PR title: "community: chinese doc extracting"

  • PR message:

    • Description: add jieba_link_extractor.py for chinese doc extracting
    • Dependencies: jieba
  • Add tests and docs: If you're adding a new integration, please include
    /doc/doc/integrations/providers/jieba.md
    /doc/doc/integrations/vectorstores/jieba_link_extractor.ipynb
    /libs/packages.yml

Sorry, something went wrong.

@andyzhou1982 andyzhou1982 requested a review from ccurme as a code owner March 7, 2025 08:15
Copy link

vercel bot commented Mar 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 8:21pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Mar 7, 2025
@andyzhou1982
Copy link
Contributor Author

Hello,I had submitted a PR(#30132) but not passed.Ccurme suggested me provide a separate packages,so I published a package named langchain-jieba on pypi,and added relevant documents.I have not provided PR for Langchain before,I don't know how to get my PR approved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
ccurme added 2 commits March 7, 2025 15:12
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Mar 7, 2025
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andyzhou1982, thanks for this, it's great that you published the package.

We don't currently feature any usage of link extractors in the docs site. They are not in the list of integration components here either. I see you added this under vector stores, but this isn't a vector store.

There is some relevant documentation in the API reference here. So I updated this PR to add a link to langchain-jieba. It will look like this:

Screenshot 2025-03-07 at 3 11 30 PM

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 7, 2025
@ccurme ccurme enabled auto-merge (squash) March 7, 2025 20:16
@ccurme ccurme merged commit 9e863c8 into langchain-ai:master Mar 7, 2025
19 checks passed
@andyzhou1982
Copy link
Contributor Author

Hello,ccurme.When I submit the PR,I did not known which module would be the most appropriate,so I selected the vector store module, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants