openai[patch]: accept json schema response format directly #27623
+64
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:M
efriis
reviewed
Oct 24, 2024
| assert actual == response_format | ||
|
|
||
| actual = _convert_to_openai_response_format(response_format["json_schema"]) | ||
| assert actual == response_format |
There was a problem hiding this comment.
should we add a test that expects strict to be passed in
| ) -> Union[Dict, TypeBaseModel]: | ||
| if isinstance(schema, type) and is_basemodel_subclass(schema): | ||
| return schema | ||
| elif "json_schema" in schema and schema.get("type") == "json_schema": |
There was a problem hiding this comment.
might be worth adding a check to confirm that passed in strict and schema strict agree and throw error if not
Co-authored-by: Erick Friis <erick@langchain.dev>
… into bagatur/fix_25460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #25460