core: Add N(naming) ruff rules #25362
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:L
| except ImportError: | ||
| raise ImportError( | ||
| "defusedxml is not installed. " | ||
| "Please install it to use the defusedxml parser." | ||
| "You can install it with `pip install defusedxml`" | ||
| "See https://github.com/tiran/defusedxml for more details" | ||
| ) | ||
| _ET = DET # Use the defusedxml parser | ||
| _et = defusedxml.ElementTree # Use the defusedxml parser |
There was a problem hiding this comment.
This variable doesn't seem to be used...
There was a problem hiding this comment.
@eyurtsev should this be used below in the fromstring?
|
@cbornet how difficult was this PR to generate? Is it relying on any auto-fixing behavior from Ruff? I'm worried about merge conflicts for 0.3 release since we're maintaining a separate branch for it and there may be merge conflicts |
Not very hard. I didn't use auto-fixing since sometimes we can't change the name for various reasons. |
ccurme
added
Ɑ: core
|
@cbornet I'll see if I can merge this one or not. And we can do other linting changes once 0.3 is out |
cbornet
changed the title
cbornet
changed the title
cbornet
force-pushed
the
ruff-core-n
branch
from
294d98c to
bb91825
Compare
|
@eyurtsev I've rebased after 0.3 merge. |
|
@cbornet hi it looks good -- but it needs another remerge since it picked up merge conflict from the other ruff change PR that was merged yesterday |
dosubot
bot
added
the
lgtm
cbornet
force-pushed
the
ruff-core-n
branch
from
bb91825 to
89a2402
Compare
Public classes/functions are not renamed and rule is ignored for them. Co-authored-by: Erick Friis <erick@langchain.dev>
Public classes/functions are not renamed and rule is ignored for them.