Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch[experimental] Fix prompt in GenerativeAgentMemory #24771

Merged

Conversation

ZhangShenao
Copy link
Contributor

There is an issue with the prompt format in GenerativeAgentMemory , try to fix it.
The prompt is same as the one in method _score_memory_importance.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 29, 2024
Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 29, 2024 9:14am

@dosubot dosubot bot added the 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature label Jul 29, 2024
@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jul 29, 2024
@ccurme ccurme merged commit 4a05679 into langchain-ai:master Jul 29, 2024
17 checks passed
@ZhangShenao ZhangShenao deleted the fix-prompt-in-GenerativeAgentMemory branch July 30, 2024 02:40
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
…ai#24771)

There is an issue with the prompt format in `GenerativeAgentMemory` ,
try to fix it.
The prompt is same as the one in method `_score_memory_importance`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants