partners/mongodb: Improved search index commands #24745
Merged
+260
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… waits for free clusters and tests.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
dosubot
bot
added
size:L
|
@efriis I'll discuss with my team how best to make tests non-trivial in the morning and get back to you. |
…e 2nd set of cases
|
Ok. Added an additional exception to pytest.raises. That's sufficient to capture all cases that I want to test that shouldn't work. |
… to capture 2nd set of cases
|
@efriis If you have a spare minute, would you please merge this? It will make the Retrievers one cleaner. |
efriis
approved these changes
Aug 1, 2024
dosubot
bot
added
the
lgtm
|
Thanks, @efriis . Appreciate the review and additional commits. |
olgamurraft
pushed a commit
to olgamurraft/langchain
that referenced
this pull request
Aug 16, 2024
Hardens index commands with try/except for free clusters and optional waits for syncing and tests. [efriis](https://github.com/efriis) These are the upgrades to the search index commands (CRUD) that I mentioned. --------- Co-authored-by: Erick Friis <erick@langchain.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hardens index commands with try/except for free clusters and optional waits for syncing and tests.
efriis These are the upgrades to the search index commands (CRUD) that I mentioned.