langchain: Make OutputFixingParser.from_llm() create a useable retry chain #24687
+23
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
scribu
force-pushed
the
output-fixing-parser-retry-chain
branch
from
7e6592e to
a49b545
Compare
scribu
force-pushed
the
output-fixing-parser-retry-chain
branch
from
4dee48c to
11f14be
Compare
dosubot
bot
added
the
size:S
dosubot
bot
added
langchain
2 tasks
|
There's a remaining lint error:
Not sure what the best way to fix it would be. |
scribu
force-pushed
the
output-fixing-parser-retry-chain
branch
from
69482dc to
2c9db0d
Compare
|
Fixed all linting errors now. |
dosubot
bot
added
size:M
This was referenced Jul 29, 2024
olgamurraft
pushed a commit
to olgamurraft/langchain
that referenced
this pull request
Aug 16, 2024
…chain (langchain-ai#24687) Description: OutputFixingParser.from_llm() creates a retry chain that returns a Generation instance, when it should actually just return a string. Issue: langchain-ai#24600 Twitter handle: scribu --------- Co-authored-by: isaac hershenson <ihershenson@hmc.edu>
olgamurraft
pushed a commit
to olgamurraft/langchain
that referenced
this pull request
Aug 16, 2024
…t retry chain (langchain-ai#25053) Description: RetryWithErrorOutputParser.from_llm() creates a retry chain that returns a Generation instance, when it should actually just return a string. This class was forgotten when fixing the issue in PR langchain-ai#24687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: OutputFixingParser.from_llm() creates a retry chain that returns a Generation instance, when it should actually just return a string.
Issue: #24600
Twitter handle: scribu