multiple: get rid of pyproject extras #22581
Merged
+3,678
−12,600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
size:XL
efriis
changed the title
dosubot
bot
added
Ɑ: vector store
added 5 commits
June 5, 2024 21:15
…/langchain into erick/uv-extended-test-deps
efriis
commented
Jun 6, 2024
efriis
commented
Jun 6, 2024
| @@ -75,7 +75,7 @@ def _convert_run_to_wb_span(self, run: Run) -> "Span": | |||
| :return: The converted Span. | |||
| """ | |||
| attributes = {**run.extra} if run.extra else {} | |||
| attributes["execution_order"] = run.execution_order | |||
| attributes["execution_order"] = run.execution_order # type: ignore | |||
There was a problem hiding this comment.
should maybe just remove?
| @@ -220,7 +220,7 @@ def _pull_queue(self) -> None: | |||
| data = MessageToJson( | |||
| pb, | |||
| preserving_proto_field_name=True, | |||
| including_default_value_fields=True, | |||
| including_default_value_fields=True, # type: ignore | |||
There was a problem hiding this comment.
should maybe be MessageToDict?
Comment on lines
78
to
83
| # Metadata creation with duckdb raises 3 warnings at the moment about reflection. | ||
| # As a stop-gap to increase strictness of pytest to fail on warnings, we'll | ||
| # explicitly catch the warning and assert that it's the one we expect. | ||
| # explicitly catch the warnings and assert that it's the one we expect. | ||
| # We may need to revisit at a later stage and determine why a warning is being | ||
| # raised here. | ||
| assert len(records) == 1 | ||
| assert len(records) == 3 |
There was a problem hiding this comment.
new versions of duckdb raise 3 warnings about data types
| @@ -1,3 +1,5 @@ | |||
| # type: ignore | |||
There was a problem hiding this comment.
type-ignoring pydantic files necessary with new mypy version
added 2 commits
June 6, 2024 13:56
efriis
commented
Jun 6, 2024
There was a problem hiding this comment.
some new version of sqlalchemy/duckdb throws 2 additional warnings. We just want to check that the duckdb one is there per #3653
added 2 commits
June 6, 2024 14:12
GaetanLepage
added a commit
to GaetanLepage/nixpkgs
that referenced
this pull request
Jun 11, 2024
hinthornw
pushed a commit
that referenced
this pull request
Jun 20, 2024
They cause `poetry lock` to take a ton of time, and `uv pip install` can resolve the constraints from these toml files in trivial time (addressing problem with #19153) This allows us to properly upgrade lockfile dependencies moving forward, which revealed some issues that were either fixed or type-ignored (see file comments)
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They cause
poetry lockto take a ton of time, anduv pip installcan resolve the constraints from these toml files in trivial time (addressing problem with #19153)This allows us to properly upgrade lockfile dependencies moving forward, which revealed some issues that were either fixed or type-ignored (see file comments)