langchain[patch]: Upgrade prompts to optional imports #21078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:M
baskaryan
reviewed
Apr 30, 2024
| # Create a way to dynamically look up deprecated imports. | ||
| # Used to consolidate logic for raising deprecation warnings and | ||
| # handling optional imports. | ||
| MODULE_LOOKUP = { |
There was a problem hiding this comment.
ooc any reason not to make this private _MODULE_LOOKUP
There was a problem hiding this comment.
Ah no reason, just inertia -- we can follow up with another refactor to make this private
baskaryan
approved these changes
Apr 30, 2024
dosubot
bot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades prompts module to use optional imports.
This code was generated with a migration script, but had to be adjusted manually a bit.
Testing in preparation for applying this code modification across the rest of the modules in langchain package to reverse the dependency
between langchain community and langchain.