Fix Cohere retriever #19771
Merged
Fix Cohere retriever #19771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
size:M
baskaryan
reviewed
Mar 29, 2024
| query: str, | ||
| *, | ||
| run_manager: CallbackManagerForRetrieverRun, | ||
| documents: Optional[List[Dict[str, str]]] = None, |
There was a problem hiding this comment.
ooc why are we passing documents into the retriever?
There was a problem hiding this comment.
It's being passed in through **kwargs either way (example here at the bottom). I am pulling it out here to make a check for the connectors. The Cohere SDK throws an error when both a connector and documents are specified, so passing None for connectors if documents are specified.
baskaryan
approved these changes
Mar 31, 2024
dosubot
bot
added
the
lgtm
marlenezw
pushed a commit
to marlenezw/langchain
that referenced
this pull request
Apr 2, 2024
* Replace `source_documents` with `documents` * Pass `documents` as a named arg vs keyword * Make `parsed_docs` more robust * Fix edge case of doc page_content being `None`
hinthornw
pushed a commit
that referenced
this pull request
Apr 26, 2024
* Replace `source_documents` with `documents` * Pass `documents` as a named arg vs keyword * Make `parsed_docs` more robust * Fix edge case of doc page_content being `None`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
source_documentswithdocumentsdocumentsas a named arg vs keywordparsed_docsmore robustNone