Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

langchain[patch]: add stop for various non-openai agents #19333

Merged
merged 3 commits into from Mar 20, 2024
Merged

langchain[patch]: add stop for various non-openai agents #19333

merged 3 commits into from Mar 20, 2024

Conversation

mackong
Copy link
Contributor

@mackong mackong commented Mar 20, 2024

  • Description: add stop for various non-openai agents.
  • Issue: N/A
  • Dependencies: N/A

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 20, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 20, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Mar 20, 2024 2:09pm

@dosubot dosubot bot added Ɑ: agent Related to agents module 🤖:improvement Medium size change to existing code to handle new use-cases labels Mar 20, 2024
@eyurtsev
Copy link
Collaborator

Looks reaasonable

@eyurtsev eyurtsev self-assigned this Mar 20, 2024
eyurtsev
eyurtsev reviewed Mar 20, 2024
View reviewed changes
libs/langchain/langchain/agents/json_chat/base.py Outdated
@@ -16,6 +16,7 @@ def create_json_chat_agent(
tools: Sequence[BaseTool],
prompt: ChatPromptTemplate,
stop_sequence: bool = True,
stop: Optional[list[str]] = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs List[str] for backwards compatibility

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 20, 2024
@eyurtsev eyurtsev added the waiting-on-author PR Status: Confirmation from author is required label Mar 20, 2024
@eyurtsev
Copy link
Collaborator

i made the change throughout the APIs for consistency, let me know if it looks good if so we can merge

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Mar 20, 2024
@eyurtsev eyurtsev merged commit d9396bd into langchain-ai:master Mar 20, 2024
41 checks passed
@mackong mackong deleted the add-stop branch March 21, 2024 00:19
rahul-trip pushed a commit to daxa-ai/langchain that referenced this pull request Mar 27, 2024
@mackong @eyurtsev @rahul-trip
langchain[patch]: add stop for various non-openai agents (langchain-a…
fb40903 
…i#19333)

* Description: add stop for various non-openai agents.
* Issue: N/A
* Dependencies: N/A

---------

Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
bechbd pushed a commit to bechbd/langchain that referenced this pull request Mar 29, 2024
@mackong @eyurtsev
langchain[patch]: add stop for various non-openai agents (langchain-a…
79182e0 
…i#19333)

* Description: add stop for various non-openai agents.
* Issue: N/A
* Dependencies: N/A

---------

Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
gkorland pushed a commit to FalkorDB/langchain that referenced this pull request Mar 30, 2024
@mackong @eyurtsev @gkorland
langchain[patch]: add stop for various non-openai agents (langchain-a…
a1eb977 
…i#19333)

* Description: add stop for various non-openai agents.
* Issue: N/A
* Dependencies: N/A

---------

Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
chrispy-snps pushed a commit to chrispy-snps/langchain that referenced this pull request Mar 30, 2024
@mackong @eyurtsev @chrispy-snps
langchain[patch]: add stop for various non-openai agents (langchain-a…
f1027d5 
…i#19333)

* Description: add stop for various non-openai agents.
* Issue: N/A
* Dependencies: N/A

---------

Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
chrispy-snps pushed a commit to chrispy-snps/langchain that referenced this pull request Mar 30, 2024
@mackong @eyurtsev @chrispy-snps
langchain[patch]: add stop for various non-openai agents (langchain-a…
5d16e35 
…i#19333)

* Description: add stop for various non-openai agents.
* Issue: N/A
* Dependencies: N/A

---------

Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
hinthornw pushed a commit that referenced this pull request Apr 26, 2024
@mackong @eyurtsev @hinthornw
langchain[patch]: add stop for various non-openai agents (#19333)
fadc4b0 
* Description: add stop for various non-openai agents.
* Issue: N/A
* Dependencies: N/A

---------

Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyurtsev eyurtsev eyurtsev approved these changes

Assignees

@eyurtsev eyurtsev

Labels
Ɑ: agent Related to agents module 🤖:improvement Medium size change to existing code to handle new use-cases lgtm PR looks good. Use to confirm that a PR is ready for merging. size:M This PR changes 30-99 lines, ignoring generated files. waiting-on-author PR Status: Confirmation from author is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mackong @eyurtsev