DOC: Possible mistake in property's docstring of ConversationBufferWindowMemory

[lgabs]

Checklist

• I added a very descriptive title to this issue.
• I included a link to the documentation page I am referring to (if applicable).

Issue with current documentation:

Readiing ConversationBufferWindowMemory class, it seems that the property buffer returns self.buffer_as_messages if self.return_messages is True, otherwise it returns self.buffer_as_str.

langchain/libs/langchain/langchain/memory/buffer_window.py

Lines 17 to 21 in 7fc9034

	@property
	def buffer(self) -> Union[str, List[BaseMessage]]:
	"""String buffer of memory."""
	return self.buffer_as_messages if self.return_messages else self.buffer_as_str

However, the docstrings of these properties buffer_as_str and return_messages seem inverted when they say True and False respectively:

langchain/libs/langchain/langchain/memory/buffer_window.py

Lines 22 to 30 in 7fc9034

	@property
	def buffer_as_str(self) -> str:
	"""Exposes the buffer as a string in case return_messages is True."""
	messages = self.chat_memory.messages[-self.k * 2 :] if self.k > 0 else []
	return get_buffer_string(
	messages,
	human_prefix=self.human_prefix,
	ai_prefix=self.ai_prefix,
	)

langchain/libs/langchain/langchain/memory/buffer_window.py

Lines 32 to 35 in 7fc9034

	@property
	def buffer_as_messages(self) -> List[BaseMessage]:
	"""Exposes the buffer as a list of messages in case return_messages is False."""
	return self.chat_memory.messages[-self.k * 2 :] if self.k > 0 else []

Idea or request for content:

No response

[keenborder786]

@lgabs nice catch ,created a PR for the fix.

[eyurtsev]

Merged

[lgabs]

@keenborder786 am I mistaken or there is still a change to make in buffer_as_messages?

https://github.com/langchain-ai/langchain/blob/master/libs/langchain/langchain/memory/buffer_window.py#L22-L36

I've updated this in this new PR: #18136