Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parameter types of context functions inferred type trees #20155

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Apr 10, 2024

A non-sensical capture reference appeared in the type of a synthesized context function literal. We do clean out @retains annotations that can contain such references, but only for inferred type trees. The problem was that context function parameters were treated like explicitly given types before.

Fixes #20135

Unverified

The signing certificate or its chain could not be verified.
…rees

A non-sensical capture reference appeared in the type of a synthesized context function
literal. We do clean out @retains annotations that can contain such references, but only
for inferred type trees. The problem was that context function parameters were treated
like explicitly given types before.

Fixes scala#20135
@odersky odersky requested a review from Linyxus April 10, 2024 16:44
Copy link
Contributor

@Linyxus Linyxus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@odersky odersky merged commit bfc8a0d into scala:main Apr 11, 2024
19 checks passed
@odersky odersky deleted the fix-20135 branch April 11, 2024 14:58
@Kordyjan Kordyjan added this to the 3.5.0 milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implicit pass of "this" to a callback crashes with capture types
3 participants