Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo update #1323

Merged
merged 3 commits into from Jul 10, 2023
Merged

Cargo update #1323

merged 3 commits into from Jul 10, 2023

Conversation

pefontana
Copy link
Member

Cargo update

Description

  • Run cargo Update
  • Fix clippy regarding lambdaworks updates

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #1323 (45d14ec) into main (ce73104) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1323      +/-   ##
==========================================
- Coverage   97.88%   97.88%   -0.01%     
==========================================
  Files          89       89              
  Lines       35473    35474       +1     
==========================================
  Hits        34724    34724              
- Misses        749      750       +1     
Impacted Files Coverage Δ
felt/src/lib_lambdaworks.rs 97.79% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pefontana pefontana enabled auto-merge July 10, 2023 17:01
@pefontana pefontana added this pull request to the merge queue Jul 10, 2023
@github-actions
Copy link

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 4.350 ± 0.003 4.341 4.353 1.00 ± 0.00
head big_factorial 4.337 ± 0.006 4.327 4.350 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 3.775 ± 0.012 3.762 3.795 1.00 ± 0.01
head big_fibonacci 3.769 ± 0.053 3.742 3.916 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 11.416 ± 0.036 11.385 11.494 1.00
head blake2s_integration_benchmark 11.546 ± 0.116 11.485 11.868 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.070 ± 0.009 4.057 4.088 1.00 ± 0.00
head compare_arrays_200000 4.050 ± 0.007 4.041 4.061 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.673 ± 0.005 2.667 2.683 1.01 ± 0.00
head dict_integration_benchmark 2.658 ± 0.005 2.651 2.665 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.994 ± 0.006 1.986 2.009 1.00
head field_arithmetic_get_square_benchmark 2.001 ± 0.008 1.990 2.020 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 10.202 ± 0.020 10.176 10.241 1.00
head integration_builtins 10.268 ± 0.024 10.249 10.329 1.01 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 11.587 ± 0.043 11.547 11.682 1.00
head keccak_integration_benchmark 11.680 ± 0.024 11.646 11.713 1.01 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.067 ± 0.010 4.057 4.084 1.00 ± 0.00
head linear_search 4.058 ± 0.006 4.051 4.067 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.930 ± 0.007 2.921 2.946 1.01 ± 0.00
head math_cmp_and_pow_integration_benchmark 2.909 ± 0.005 2.903 2.917 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.638 ± 0.009 2.626 2.653 1.01 ± 0.00
head math_integration_benchmark 2.618 ± 0.007 2.609 2.631 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.323 ± 0.006 2.316 2.335 1.00 ± 0.00
head memory_integration_benchmark 2.312 ± 0.007 2.300 2.324 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.587 ± 0.004 2.580 2.594 1.00 ± 0.00
head operations_with_data_structures_benchmarks 2.580 ± 0.008 2.568 2.591 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 870.6 ± 0.8 869.6 871.9 1.00 ± 0.00
head pedersen 870.6 ± 2.1 866.4 874.0 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.590 ± 0.004 1.584 1.595 1.00
head poseidon_integration_benchmark 1.592 ± 0.004 1.588 1.600 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.075 ± 0.005 3.067 3.087 1.00 ± 0.00
head secp_integration_benchmark 3.070 ± 0.005 3.060 3.076 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.555 ± 0.012 1.548 1.588 1.05 ± 0.01
head set_integration_benchmark 1.485 ± 0.003 1.481 1.490 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 7.393 ± 0.020 7.367 7.433 1.00
head uint256_integration_benchmark 7.411 ± 0.048 7.374 7.533 1.00 ± 0.01

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 10, 2023
@pefontana pefontana added this pull request to the merge queue Jul 10, 2023
Merged via the queue into main with commit 78a64b0 Jul 10, 2023
34 checks passed
@pefontana pefontana deleted the cargo-update branch July 10, 2023 17:53
@pefontana pefontana mentioned this pull request Jul 15, 2023
6 tasks
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
* cargo update

* Fix clippy

* Update CHANGELOG
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
* cargo update

* Fix clippy

* Update CHANGELOG
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants