Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check all features on each crate #1312

Merged
merged 6 commits into from Jul 4, 2023
Merged

Conversation

MegaRedHand
Copy link
Contributor

@MegaRedHand MegaRedHand commented Jul 3, 2023

Closes: #1304

Description

cargo check-all-features seems to compile crates while using their default features (noticed after running it with --verbose and no compiled dependencies). This results in no compile failures reported when running it even if one combination doesn't really work (for example, cairo-felt without any features).

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@MegaRedHand MegaRedHand added the pipelines This PR/issue is exclusively about improving our CI label Jul 3, 2023
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #1312 (6daa279) into main (a1ec8d8) will increase coverage by 0.00%.
The diff coverage is 77.77%.

@@           Coverage Diff           @@
##             main    #1312   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files          89       89           
  Lines       35471    35474    +3     
=======================================
+ Hits        34727    34730    +3     
  Misses        744      744           
Impacted Files Coverage Δ
...processor/cairo_1_hint_processor/hint_processor.rs 84.99% <33.33%> (ø)
felt/src/lib_lambdaworks.rs 97.79% <100.00%> (ø)
...sor/cairo_1_hint_processor/hint_processor_utils.rs 73.19% <100.00%> (+0.85%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MegaRedHand MegaRedHand marked this pull request as ready for review July 3, 2023 22:15
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 4.236 ± 0.015 4.217 4.267 1.00
head big_factorial 4.240 ± 0.013 4.223 4.264 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 3.606 ± 0.008 3.597 3.620 1.00 ± 0.00
head big_fibonacci 3.605 ± 0.007 3.596 3.620 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 11.247 ± 0.136 11.172 11.627 1.00 ± 0.01
head blake2s_integration_benchmark 11.231 ± 0.051 11.184 11.351 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.944 ± 0.012 3.929 3.970 1.00
head compare_arrays_200000 3.946 ± 0.009 3.936 3.962 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.611 ± 0.011 2.594 2.626 1.00
head dict_integration_benchmark 2.617 ± 0.008 2.605 2.629 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.942 ± 0.011 1.933 1.971 1.00 ± 0.01
head field_arithmetic_get_square_benchmark 1.940 ± 0.007 1.933 1.956 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 10.072 ± 0.076 9.954 10.194 1.00
head integration_builtins 10.138 ± 0.068 10.019 10.267 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 11.539 ± 0.272 11.316 12.278 1.01 ± 0.03
head keccak_integration_benchmark 11.429 ± 0.099 11.306 11.594 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.012 ± 0.015 3.995 4.039 1.00
head linear_search 4.016 ± 0.022 3.976 4.061 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.838 ± 0.006 2.829 2.850 1.00
head math_cmp_and_pow_integration_benchmark 2.863 ± 0.030 2.832 2.915 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.632 ± 0.034 2.609 2.726 1.01 ± 0.01
head math_integration_benchmark 2.614 ± 0.010 2.600 2.634 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.299 ± 0.011 2.282 2.312 1.00 ± 0.01
head memory_integration_benchmark 2.289 ± 0.012 2.273 2.309 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.511 ± 0.007 2.503 2.524 1.00 ± 0.00
head operations_with_data_structures_benchmarks 2.508 ± 0.007 2.500 2.524 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 847.5 ± 1.6 845.5 850.9 1.00
head pedersen 849.1 ± 3.8 845.9 858.6 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.591 ± 0.003 1.587 1.595 1.00 ± 0.00
head poseidon_integration_benchmark 1.591 ± 0.003 1.588 1.596 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.042 ± 0.007 3.036 3.058 1.00 ± 0.00
head secp_integration_benchmark 3.031 ± 0.010 3.014 3.043 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.680 ± 0.003 1.675 1.686 1.00 ± 0.00
head set_integration_benchmark 1.675 ± 0.002 1.671 1.678 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 7.245 ± 0.028 7.215 7.301 1.00
head uint256_integration_benchmark 7.326 ± 0.042 7.279 7.436 1.01 ± 0.01

@pefontana pefontana added this pull request to the merge queue Jul 4, 2023
Merged via the queue into main with commit ddf817b Jul 4, 2023
34 of 35 checks passed
@pefontana pefontana deleted the fix-check-all-features branch July 4, 2023 17:42
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
* Remove some `std` uses from cairo 1 hint processor

* Fix smoke job

* Fix ["alloc"] compilation of cairo-felt

* Split check-all-features into one for each crate

* Cache on failure

* Fix cairo-1-hints compilation
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
* Remove some `std` uses from cairo 1 hint processor

* Fix smoke job

* Fix ["alloc"] compilation of cairo-felt

* Split check-all-features into one for each crate

* Cache on failure

* Fix cairo-1-hints compilation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pipelines This PR/issue is exclusively about improving our CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check the Make sure all builds work GitHub Action workflow
3 participants