New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check all features on each crate #1312
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
added
the
pipelines
This PR/issue is exclusively about improving our CI
label
Jul 3, 2023
Codecov Report
@@ Coverage Diff @@
## main #1312 +/- ##
=======================================
Coverage 97.90% 97.90%
=======================================
Files 89 89
Lines 35471 35474 +3
=======================================
+ Hits 34727 34730 +3
Misses 744 744
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
MegaRedHand
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
July 3, 2023 22:15
Benchmark Results for unmodified programs 🚀
|
Oppen
reviewed
Jul 4, 2023
Oppen
approved these changes
Jul 4, 2023
pefontana
approved these changes
Jul 4, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jul 25, 2023
* Remove some `std` uses from cairo 1 hint processor * Fix smoke job * Fix ["alloc"] compilation of cairo-felt * Split check-all-features into one for each crate * Cache on failure * Fix cairo-1-hints compilation
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jul 25, 2023
* Remove some `std` uses from cairo 1 hint processor * Fix smoke job * Fix ["alloc"] compilation of cairo-felt * Split check-all-features into one for each crate * Cache on failure * Fix cairo-1-hints compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1304
Description
cargo check-all-features
seems to compile crates while using their default features (noticed after running it with--verbose
and no compiled dependencies). This results in no compile failures reported when running it even if one combination doesn't really work (for example, cairo-felt without any features).Checklist