Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump dependency versions #1309

Merged
merged 4 commits into from Jul 4, 2023
Merged

chore: bump dependency versions #1309

merged 4 commits into from Jul 4, 2023

Conversation

MegaRedHand
Copy link
Contributor

Description

This PR updates the dependencies. Among other things, it updates the clap version from 3.2.5 to 4.3.10 and addresses its API changes. Combined with the criterion dependency update, this should fix https://github.com/lambdaclass/cairo-vm/security/dependabot/6.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #1309 (62975a6) into main (a1ec8d8) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1309      +/-   ##
==========================================
- Coverage   97.90%   97.88%   -0.02%     
==========================================
  Files          89       89              
  Lines       35471    35470       -1     
==========================================
- Hits        34727    34721       -6     
- Misses        744      749       +5     
Impacted Files Coverage Δ
cairo-vm-cli/src/main.rs 92.24% <100.00%> (-3.91%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 4.918 ± 0.101 4.852 5.181 1.00
head big_factorial 4.947 ± 0.065 4.899 5.125 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 4.178 ± 0.015 4.152 4.202 1.00
head big_fibonacci 4.242 ± 0.132 4.178 4.614 1.02 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 13.203 ± 0.215 12.931 13.740 1.01 ± 0.02
head blake2s_integration_benchmark 13.036 ± 0.155 12.699 13.237 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 4.528 ± 0.047 4.470 4.611 1.00
head compare_arrays_200000 4.561 ± 0.012 4.541 4.577 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 3.091 ± 0.136 2.995 3.322 1.03 ± 0.05
head dict_integration_benchmark 3.006 ± 0.014 2.985 3.022 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 4.885 ± 0.016 4.863 4.912 1.00
head factorial_multirun 4.927 ± 0.091 4.869 5.181 1.01 ± 0.02
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 4.220 ± 0.132 4.107 4.565 1.00
head fibonacci_1000_multirun 4.239 ± 0.061 4.199 4.402 1.00 ± 0.03
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 2.273 ± 0.027 2.226 2.301 1.01 ± 0.02
head field_arithmetic_get_square_benchmark 2.248 ± 0.030 2.199 2.290 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 11.657 ± 0.082 11.457 11.765 1.00
head integration_builtins 11.760 ± 0.096 11.597 11.907 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 13.258 ± 0.089 13.056 13.406 1.00
head keccak_integration_benchmark 13.312 ± 0.159 13.139 13.698 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 4.535 ± 0.033 4.499 4.573 1.00 ± 0.02
head linear_search 4.528 ± 0.075 4.462 4.730 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 3.288 ± 0.021 3.257 3.329 1.00 ± 0.01
head math_cmp_and_pow_integration_benchmark 3.286 ± 0.021 3.249 3.312 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.986 ± 0.050 2.945 3.118 1.01 ± 0.02
head math_integration_benchmark 2.965 ± 0.017 2.934 2.990 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.616 ± 0.052 2.578 2.715 1.01 ± 0.02
head memory_integration_benchmark 2.592 ± 0.029 2.557 2.665 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.935 ± 0.077 2.878 3.150 1.01 ± 0.03
head operations_with_data_structures_benchmarks 2.898 ± 0.029 2.849 2.945 1.00
Command Mean [s] Min [s] Max [s] Relative
base pedersen 1.002 ± 0.006 0.995 1.016 1.00
head pedersen 1.007 ± 0.004 1.001 1.013 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.820 ± 0.010 1.801 1.833 1.01 ± 0.01
head poseidon_integration_benchmark 1.796 ± 0.015 1.762 1.812 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 3.536 ± 0.159 3.398 3.906 1.02 ± 0.05
head secp_integration_benchmark 3.466 ± 0.081 3.346 3.635 1.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.806 ± 0.046 1.767 1.933 1.01 ± 0.03
head set_integration_benchmark 1.794 ± 0.008 1.775 1.803 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 8.415 ± 0.083 8.294 8.609 1.00 ± 0.01
head uint256_integration_benchmark 8.381 ± 0.021 8.355 8.425 1.00

Copy link
Member

@pefontana pefontana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @MegaRedHand !

@Oppen Oppen added this pull request to the merge queue Jul 4, 2023
Merged via the queue into main with commit d8aa124 Jul 4, 2023
34 checks passed
@Oppen Oppen deleted the bump-deps branch July 4, 2023 00:56
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 4, 2023
* Bump dependencies

* Update changelog

---------

Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 4, 2023
* Bump dependencies

* Update changelog

---------

Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
* Bump dependencies

* Update changelog

---------

Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
* Bump dependencies

* Update changelog

---------

Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants