Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lambdaworks-felt flag for cli #1308

Merged
merged 2 commits into from Jul 4, 2023
Merged

feat: lambdaworks-felt flag for cli #1308

merged 2 commits into from Jul 4, 2023

Conversation

Oppen
Copy link
Member

@Oppen Oppen commented Jul 3, 2023

Allow using lambdaworks for the CLI

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Merging #1308 (0526732) into main (d8aa124) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1308   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files          89       89           
  Lines       35470    35470           
=======================================
  Hits        34721    34721           
  Misses        749      749           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 3.876 ± 0.021 3.856 3.925 1.00 ± 0.01
head big_factorial 3.868 ± 0.020 3.851 3.916 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 3.350 ± 0.014 3.336 3.373 1.00 ± 0.01
head big_fibonacci 3.345 ± 0.024 3.321 3.401 1.00
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 10.893 ± 0.042 10.851 10.964 1.00 ± 0.00
head blake2s_integration_benchmark 10.873 ± 0.029 10.843 10.926 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.690 ± 0.010 3.678 3.708 1.00
head compare_arrays_200000 3.691 ± 0.009 3.676 3.708 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.481 ± 0.014 2.463 2.508 1.00 ± 0.01
head dict_integration_benchmark 2.477 ± 0.009 2.466 2.494 1.00
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 3.877 ± 0.016 3.859 3.909 1.00 ± 0.01
head factorial_multirun 3.876 ± 0.016 3.859 3.906 1.00
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 3.365 ± 0.027 3.327 3.417 1.00 ± 0.01
head fibonacci_1000_multirun 3.351 ± 0.013 3.338 3.377 1.00
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.946 ± 0.014 1.929 1.972 1.00 ± 0.01
head field_arithmetic_get_square_benchmark 1.939 ± 0.009 1.929 1.958 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 9.776 ± 0.067 9.703 9.925 1.00
head integration_builtins 9.859 ± 0.085 9.793 10.079 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 11.042 ± 0.078 10.952 11.207 1.00 ± 0.01
head keccak_integration_benchmark 10.998 ± 0.049 10.936 11.070 1.00
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.724 ± 0.015 3.704 3.756 1.00 ± 0.01
head linear_search 3.722 ± 0.013 3.708 3.747 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.609 ± 0.037 2.583 2.711 1.01 ± 0.01
head math_cmp_and_pow_integration_benchmark 2.587 ± 0.005 2.579 2.596 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.379 ± 0.007 2.369 2.392 1.00
head math_integration_benchmark 2.384 ± 0.008 2.374 2.401 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.103 ± 0.010 2.087 2.118 1.00
head memory_integration_benchmark 2.103 ± 0.012 2.093 2.126 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.384 ± 0.007 2.378 2.400 1.01 ± 0.00
head operations_with_data_structures_benchmarks 2.362 ± 0.006 2.354 2.373 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 844.0 ± 1.7 841.8 847.9 1.00
head pedersen 844.7 ± 2.1 842.2 847.7 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.581 ± 0.005 1.573 1.591 1.00 ± 0.01
head poseidon_integration_benchmark 1.580 ± 0.009 1.574 1.603 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.744 ± 0.010 2.733 2.766 1.00
head secp_integration_benchmark 2.746 ± 0.010 2.733 2.758 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.317 ± 0.012 1.310 1.350 1.00
head set_integration_benchmark 1.318 ± 0.003 1.314 1.324 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 6.975 ± 0.017 6.952 6.997 1.00 ± 0.00
head uint256_integration_benchmark 6.970 ± 0.016 6.949 6.998 1.00

Copy link
Member

@pefontana pefontana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to double-check.
The Default compilation of vm-cli will still be with de old Felt252 no?
I think it is ok to add the feature but all are focus and the CI checks should be done with the old Felt252, since it is what will be released to production

@Oppen
Copy link
Member Author

Oppen commented Jul 4, 2023

Just to double-check.
The Default compilation of vm-cli will still be with de old Felt252 no?
I think it is ok to add the feature but all are focus and the CI checks should be done with the old Felt252, since it is what will be released to production

The default remains the old Felt252 with num-bigint backend, yes.

@pefontana pefontana enabled auto-merge July 4, 2023 14:30
@pefontana pefontana added this pull request to the merge queue Jul 4, 2023
Merged via the queue into main with commit 7328075 Jul 4, 2023
34 checks passed
@pefontana pefontana deleted the feat/lambdaworks_feat branch July 4, 2023 15:02
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jul 25, 2023
Co-authored-by: Pedro Fontana <fontana.pedro93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants