Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make-deps commands should intall pyenv #1242

Closed
pefontana opened this issue Jun 15, 2023 · 2 comments
Closed

make-deps commands should intall pyenv #1242

pefontana opened this issue Jun 15, 2023 · 2 comments
Assignees
@MegaRedHand
Milestone
0.6.0

Comments

@pefontana
Copy link
Member

Make deps and Make deps-macos should install pyenv.
@pefontana pefontana added this to the 0.6.0 milestone Jun 15, 2023
@Oppen
Copy link
Member

Oppen commented Jun 19, 2023

The process is highly dependent on the users' platform, so there's no generic way to install this in the target. Instead, the need should be properly documented, with the procedure for some common platforms (off the top of my head, MacOS, Windows, Ubuntu, Debian, CentOS/Red Hat, as those are the most popular ones) explained as well, and if at all possible make deps should fail with a clear message and point to the docs if it can't find pyenv.
We have a pipeline that checks all of this is installable IIRC, so the commands can be found there.

@MegaRedHand MegaRedHand self-assigned this Jun 29, 2023
@MegaRedHand
Copy link
Contributor

Addressed in #1298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MegaRedHand MegaRedHand

Labels
None yet
Projects
Starknet
Status: Done
Milestone
0.6.0
Development

No branches or pull requests
3 participants
@Oppen @MegaRedHand @pefontana