New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate RunResources
logic into HintProcessor
trait
#1274
Conversation
Signed-off-by: Dori Medini <dori@starkware.co>
Codecov Report
@@ Coverage Diff @@
## main #1274 +/- ##
==========================================
- Coverage 97.60% 97.57% -0.04%
==========================================
Files 89 89
Lines 36335 36132 -203
==========================================
- Hits 35466 35254 -212
- Misses 869 878 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -55,6 +51,9 @@ pub trait HintProcessor { | |||
} | |||
} | |||
|
|||
pub trait HintProcessor: HintProcessorLogic + ResourceTracker {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about renaming HintProcessor
-> HypervisorContext
and HintProcessorLogic
-> HintProcessor
?
(Hypervisor: something "that creates and runs virtual machines". Seems fitting)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or even just Hypervisor
...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm more in favor of something like plainly Context
(since that's likely to be extended in the future), but I'd rather not do the bikeshedding while the urgency is still in need of fixing. We can fix those details during the week, after solving the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"that creates and runs virtual machines", wouldn't that be the CairoRunner
itself?
I agree with @Oppen Context
is less confusing
…s#1274) * RunResources into context Signed-off-by: Dori Medini <dori@starkware.co> * Fix broken code under `cairo-1-hints` feature * Add changelog entry --------- Signed-off-by: Dori Medini <dori@starkware.co> Co-authored-by: Dori Medini <dori@starkware.co>
…s#1274) * RunResources into context Signed-off-by: Dori Medini <dori@starkware.co> * Fix broken code under `cairo-1-hints` feature * Add changelog entry --------- Signed-off-by: Dori Medini <dori@starkware.co> Co-authored-by: Dori Medini <dori@starkware.co>
…s#1274) * RunResources into context Signed-off-by: Dori Medini <dori@starkware.co> * Fix broken code under `cairo-1-hints` feature * Add changelog entry --------- Signed-off-by: Dori Medini <dori@starkware.co> Co-authored-by: Dori Medini <dori@starkware.co>
…s#1274) * RunResources into context Signed-off-by: Dori Medini <dori@starkware.co> * Fix broken code under `cairo-1-hints` feature * Add changelog entry --------- Signed-off-by: Dori Medini <dori@starkware.co> Co-authored-by: Dori Medini <dori@starkware.co>
Fixes CI warnings for #1272
Checklist