fix: TestAgent not inheriting Agent properties #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bruception
commented
Apr 24, 2024
| @@ -26,7 +26,9 @@ const Test = require('./test.js'); | |||
| function TestAgent(app, options = {}) { | |||
| if (!(this instanceof TestAgent)) return new TestAgent(app, options); | |||
|
|
|||
| Agent.call(this, options); | |||
| const agent = new Agent(options); | |||
There was a problem hiding this comment.
Looks like this commit to change from functions to classes breaks this behavior.
ladjs/superagent@fca95a3
The apply hook in the Proxy seems to discard the this reference and so it is not being binded.
There was a problem hiding this comment.
This looks promising (and explanation makes sense) 👀
Bruception
changed the title
Bruception
changed the title
matsoob
approved these changes
Apr 24, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#833
Checklist