Skip to content

Commit 8847310

Browse files
committedOct 3, 2022
refactor(test): do not hardcode any ports, use ephemeral ports
1 parent c1c4402 commit 8847310

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed
 

Diff for: ‎test/supertest.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ describe('request(app)', function () {
8080
res.send('hey');
8181
});
8282

83-
server = app.listen(4000, function () {
83+
server = app.listen(function () {
8484
request(server)
8585
.get('/')
8686
.end(function (err, res) {
@@ -99,8 +99,9 @@ describe('request(app)', function () {
9999
res.send('hey');
100100
});
101101

102-
server = app.listen(4001, function () {
103-
request('http://localhost:4001')
102+
server = app.listen(function () {
103+
const url = 'http://localhost:' + server.address().port;
104+
request(url)
104105
.get('/')
105106
.end(function (err, res) {
106107
res.status.should.equal(200);

0 commit comments

Comments
 (0)
Please sign in to comment.