fix(https2): ipv6 addresses url #1829
Merged
+19
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Follow up to #1805
The reason http2 was failing is that the
http2wrapper
module was building a url based off of the host, and that needs to be wrapped in square brackets when constructing the string if it is an ipv6. In the case of thehttp
module, it sends a request using theoptions
object, and in that case, the host ip address should not be wrapped in square brackets