Skip to content

Commit 07954a1

Browse files
committedJun 11, 2024··
fix?
1 parent d688596 commit 07954a1

File tree

2 files changed

+13
-16
lines changed

2 files changed

+13
-16
lines changed
 

Diff for: ‎.github/workflows/ci.yml

-5
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,6 @@ jobs:
2020
steps:
2121
- uses: actions/checkout@v3
2222

23-
# This is necessary because GitHub Actions does not support IPv6 yet
24-
# And if a user has `ipv6: true` set in their yaml config, it wouldn't work otherwise
25-
# <https://github.com/actions/runner-images/issues/668#issuecomment-1872487355>
26-
- name: Setup WARP
27-
uses: fscarmen/warp-on-actions@v1.1
2823
- name: Install Node - ${{ matrix.node-version }}
2924
uses: actions/setup-node@v3
3025
with:

Diff for: ‎test/node/basic.js

+13-11
Original file line numberDiff line numberDiff line change
@@ -134,21 +134,23 @@ describe('[node] request', () => {
134134
});
135135
});
136136

137-
describe('ipv6 address', () => {
138-
it('should successfully query an ipv6 address', (done) => {
139-
request.get(`http://[::]:${process.env.ZUUL_PORT}/url?a=(b%29`).end((error, res) => {
140-
assert.equal('/url?a=(b%29', res.text);
141-
done();
137+
if (doesntWorkInHttp2) {
138+
describe('ipv6 address', () => {
139+
it('should successfully query an ipv6 address', (done) => {
140+
request.get(`http://[::]:${process.env.ZUUL_PORT}/url?a=(b%29`).end((error, res) => {
141+
assert.equal('/url?a=(b%29', res.text);
142+
done();
143+
});
142144
});
143-
});
144145

145-
it('should successfully query an ipv6 address', (done) => {
146-
request.get(`http://[::1]:${process.env.ZUUL_PORT}/url?a=(b%29`).end((error, res) => {
147-
assert.equal('/url?a=(b%29', res.text);
148-
done();
146+
it('should successfully query an ipv6 address', (done) => {
147+
request.get(`http://[::1]:${process.env.ZUUL_PORT}/url?a=(b%29`).end((error, res) => {
148+
assert.equal('/url?a=(b%29', res.text);
149+
done();
150+
});
149151
});
150152
});
151-
});
153+
}
152154

153155
describe('.buffer()', () => {
154156
it('should enable buffering', (done) => {

0 commit comments

Comments
 (0)
Please sign in to comment.